Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interceptor TLS support to the add-on chart #642

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

zorocloud
Copy link
Contributor

@zorocloud zorocloud commented May 24, 2024

Provide a description of what has been changed

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Adding support for TLS to the interceptor proxy in the HTTP Add-on. Resolves kedacore/http-add-on#1028

@zorocloud zorocloud requested a review from a team as a code owner May 24, 2024 15:24
@zorocloud
Copy link
Contributor Author

Re the 3rd item in the checklist (updating the README), do I need to run helm-docs to generate a new README now or will that be done at the time of release?

@kamialie
Copy link
Contributor

kamialie commented Jun 5, 2024

@zorocloud considering the fact that when I ran it for my PR I noticed that some change from another PR was applied, I believe you have to run it yourself.

@zroubalik
Copy link
Member

Re the 3rd item in the checklist (updating the README), do I need to run helm-docs to generate a new README now or will that be done at the time of release?

yes please

Signed-off-by: Joe Wogan <joe.wogan@10xbanking.com>
@zorocloud
Copy link
Contributor Author

Thanks for confirming. I have updated the PR post running helm-docs now 👍 .

@JorTurFer JorTurFer merged commit 650d761 into kedacore:main Jun 24, 2024
9 checks passed
@JorTurFer
Copy link
Member

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS requests are sent over HTTP instead of HTTPS
4 participants