Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keda-crd helm chart #675

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add keda-crd helm chart #675

wants to merge 1 commit into from

Conversation

ecerulm
Copy link

@ecerulm ecerulm commented Aug 5, 2024

Provide a description of what has been changed

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes kedacore/keda#5575

@ecerulm ecerulm requested a review from a team as a code owner August 5, 2024 18:08
Signed-off-by: Rubén Laguna <ruben.laguna@gmail.com>
@JorTurFer
Copy link
Member

WDYT @tomkerkhove @zroubalik ? Maybe we can split the CRDs into a new fully isolated chart and deploy that chart as dependency of KEDA (managed by a flag). This could allow installing the CRDs in advantage, without losing the helm support for the chart.
This PR adds a symlink, but maybe we could iterate this

@tomkerkhove
Copy link
Member

As per #226, dependency does not work properly

@JorTurFer
Copy link
Member

No no, I meant the CRDs chart as KEDA chart dependecy, not KEDA as user dependency

@tomkerkhove
Copy link
Member

I know, but I believe the problem will be the same - There is no guarantee that CRDs are created first nor that they will be updated (biggest issue)

@sofuture
Copy link

sofuture commented Sep 6, 2024

This would be quite nice to have, what's between here and :shipit: ?

@pragmaticivan
Copy link
Contributor

Worth mentioning that Karpenter moved away from Symlinks due to some conflict on updates across major versions.

aws/karpenter-provider-aws@a69a377

(Mention since this came from an issue referring to Karpenter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a helm chart just for the CRDs like karpenter does
5 participants