Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating our containers to GitHub Container Registry #16

Closed
tomkerkhove opened this issue Feb 17, 2021 · 11 comments · Fixed by kedacore/keda#2562
Closed

Migrating our containers to GitHub Container Registry #16

tomkerkhove opened this issue Feb 17, 2021 · 11 comments · Fixed by kedacore/keda#2562
Assignees
Labels
adoption governance All issues related to governance of project release-management

Comments

@tomkerkhove
Copy link
Member

We've discussed it in the past (see kedacore/keda#995) but I think it's time to migrate our Docker images to GitHub Container Registry which brings our artifacts closer to our GitHub repos and gives us more insights on the adoption (# of pulls per tag, instead of vague total pull count).

We are dry-running this for our HTTP add-on and it's fairly straightforward.

Here is how people can discover them:
image

Per Docker image, you can then see the pull count per tag:
image

I've used this on other projects as well and it gives you a lot more insights than Docker Hub, and would never move back.

⚠ If we do this, then we should move all Docker images to our new registry for sake of completeness, but keep the old ones on Docker Hub.

@tomkerkhove
Copy link
Member Author

Thoughts @kedacore/keda-maintainers?

@tomkerkhove
Copy link
Member Author

Happy to pick this up.

@zroubalik
Copy link
Member

Sounds good!

@tomkerkhove
Copy link
Member Author

Thoughts on this @jeffhollan @anirudhgarg @ahmelsayed?

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Mar 3, 2021

Yesterday we've agreed that this is the way forward, but we'll publish them in both Docker Hub & GitHub Container Registry until GHCR is out of preview.

We will:

(Meeting notes)

@tomkerkhove
Copy link
Member Author

I'd propose to write a small blog post with this as well, next to the GitHub Discussion, what do you think?

@tomkerkhove tomkerkhove self-assigned this Mar 3, 2021
@tomkerkhove tomkerkhove changed the title Proposal to move our Docker images to GitHub Container Registry Migrating our containers to GitHub Container Registry Mar 3, 2021
@tomkerkhove
Copy link
Member Author

Blog post is published on https://keda.sh/blog/migrating-to-github-container-registry/ and discussion is open on kedacore/keda#1700

@tomkerkhove
Copy link
Member Author

GHCR is GA, it's time to remove Docker Hub support and close this deprecation.

Agreed @kedacore/keda-maintainers? Happy to pick this up.

@tomkerkhove tomkerkhove added governance All issues related to governance of project release-management and removed proposal labels Nov 26, 2021
@JorTurFer
Copy link
Member

I agree

@zroubalik
Copy link
Member

+1

tomkerkhove added a commit to kedacore/keda that referenced this issue Jan 26, 2022
No longer push to Docker Hub on release as per kedacore/governance#16

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
tomkerkhove added a commit to kedacore/keda that referenced this issue Jan 26, 2022
No longer push to Docker Hub on release as per kedacore/governance#16

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
tomkerkhove added a commit to kedacore/keda that referenced this issue Jan 26, 2022
No longer push to Docker Hub on release as per kedacore/governance#16

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
tomkerkhove added a commit to kedacore/keda that referenced this issue Jan 26, 2022
No longer push to Docker Hub on release as per kedacore/governance#16

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove
Copy link
Member Author

KEDA v2.6 will only be available on GitHub Container Registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adoption governance All issues related to governance of project release-management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants