Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime.Object is nil error on the logs of the interceptor pod #174

Closed
ajanth97 opened this issue Jun 2, 2021 · 2 comments · Fixed by #181
Closed

runtime.Object is nil error on the logs of the interceptor pod #174

ajanth97 opened this issue Jun 2, 2021 · 2 comments · Fixed by #181
Assignees
Labels
bug Something isn't working

Comments

@ajanth97
Copy link
Collaborator

ajanth97 commented Jun 2, 2021

2021/06/02 16:31:35 Interceptor started, forwarding to service bal-test:80, watching deployment bal-test
2021/06/02 16:31:35 proxy server starting on 0.0.0.0:8091
2021/06/02 16:31:35 admin server running on 0.0.0.0:8090


/ // / ___
/ // / _ / _
/
/_
////___/ v4.2.2
High performance, minimalist Go web framework
https://echo.labstack.com
_____________________________O/
O
⇨ http server started on [::]:8090
panic: interface conversion: runtime.Object is nil, not *v1.Deployment

goroutine 38 [running]:
github.com/kedacore/http-add-on/pkg/k8s.NewK8sDeploymentCache.func1(0x16ccc78, 0xc0003765c0, 0xc0004a2ff0)
/go/src/github.com/kedahttp/http-add-on/pkg/k8s/deployment_cache.go:60 +0x226
created by github.com/kedacore/http-add-on/pkg/k8s.NewK8sDeploymentCache
/go/src/github.com/kedahttp/http-add-on/pkg/k8s/deployment_cache.go:52 +0x359

@ajanth97 ajanth97 added the bug Something isn't working label Jun 2, 2021
@ajanth97 ajanth97 changed the title runtime.Object is nil error on the logs of the interface pod runtime.Object is nil error on the logs of the interceptor pod Jun 2, 2021
@arschles
Copy link
Collaborator

@ajanth97 thanks for finding/reporting this! I think the error comes from here, where we're not checking if the type assertion worked. In fact, we're doing a similar thing here: https://github.com/kedacore/http-add-on/blob/main/interceptor/forward_wait_func.go#L41. In the latter case. I'll submit a PR to fix both.

arschles added a commit to arschles/http-add-on that referenced this issue Jun 15, 2021
Fixes kedacore#174

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles self-assigned this Jun 15, 2021
@ajanth97
Copy link
Collaborator Author

@arschles thank you, will look into this shortly

tomkerkhove added a commit that referenced this issue Jul 1, 2021
Fixes #174

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
arschles added a commit to arschles/http-add-on that referenced this issue Aug 18, 2021
Fixes kedacore#174

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants