Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding endpoint on interceptors to reveal the routing table version history #246

Closed
wants to merge 52 commits into from
Closed

Adding endpoint on interceptors to reveal the routing table version history #246

wants to merge 52 commits into from

Conversation

arschles
Copy link
Collaborator

@arschles arschles commented Aug 30, 2021 •
edited
Loading

This PR adds in-memory storage to the interceptors for the routing table version (the same identifier as the Kube ConfigMap resource version), and exposes it via a REST API endpoint.

This PR is submitted as a draft and intended to be reviewed and merged after #206 is complete

Update: #206 is merged, and this PR is taken out of draft status. It is ready for review.

Checklist

  • Fix build breakage
  • Any necessary documentation is added, such as:
  • Commits are signed with Developer Certificate of Origin (DCO)
  • Split the routing table into reader, writer, and versioner interfaces for use in interceptor vs. operator

Fixes #225

arschles and others added 30 commits August 18, 2021 15:05
@arschles
multi-tenant interceptor and scaler
43e8eff 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
Merge branch 'main' of github.com:kedacore/http-add-on into global-co…
cbe11ec 
…mponents

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Merge branch 'main' of github.com:kedacore/http-add-on into global-co…
7bb4e11 
…mponents

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
specifying host in XKCD ingress
9d7fae6 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
routing the xkcd chart to the interceptor properly
e6a6d67 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
check host header first
20dac47 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
sending true active response in stream
a3c0403 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
passing target pending requests through to the underlying ScaledObjec…
ff8a3c0 
…t (so the scaler can read it later)

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
removing broken target pending requests
ee8ef79 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
using getHost in proxy handler
966e8ce 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding integration test
b96f209 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding more tests to the integration test
1123c70 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
splitting up integration tests
013915e 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
more checks
f63ad32 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
mark new test TODO
37fe73b 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
expanding interceptor integration tests
6078beb 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
error messages
18452c3 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
refactor test
9b708e0 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
more test improvements
8db0df4 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
rolling back target pending requests in ScaledObject
647eaae 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
removing target metric error. it's not used anymore
3b34131 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
improving waitFunc test
9bda86e 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Refactoring the deployment cache to add better error handing and resi…
76117d5 
…lience.

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding doc comment
69d4c0f 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
refactoring deploy cache and adding tests
1039b92 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Using interfaces for deployment watch & list
bebce95 
this makes tests easier

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding more deploy cache tests
904b754 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Fixing up TestK8sDeploymentCacheRewatch
0c1dd47 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
shutting down everything else when one thing errors, and adding a dep…
ae28597 
…loyments cache endpoint

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
removing commented code
a083ac7 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
integration_tets ==> proxy_handlers_integration_test
1539e34 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding some resilience to tests
02abdb6 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding deployment cache endpoint documentation
db588d0 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Merge branch 'main' of github.com:kedacore/http-add-on into global-co…
0bc461b 
…mponents

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
running the global test target with sh.RunV
b45fd22 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding timeout to magefile test target
570e259 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
finishing one TODO test and adding issue for the rest:
0a3b321 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Adding interceptor endpoints to reveal the routing table version
3d36334 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles arschles mentioned this pull request Aug 30, 2021
Merged
29 tasks
@arschles
Merge branch 'main' of github.com:kedacore/http-add-on into routing-vsn
26d8bff 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
splitting table and table version interfaces apart
4b85533 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
fixing tests
1a570c6 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles arschles marked this pull request as ready for review September 7, 2021 21:48
@arschles
Merge branch 'main' of github.com:kedacore/http-add-on into routing-vsn
0e6faf5 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles requested a review from ajanth97 as a code owner September 21, 2021 23:47
arschles and others added 3 commits September 22, 2021 19:59
@arschles
adding godoc comments to the TableAndVersionHistory type and construc…
5201829 
…tor func

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
fixing scaler build
777f03b 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
Merge branch 'main' into routing-vsn
42b2298
@arschles arschles added this to the v0.3.0 milestone Sep 22, 2021
@arschles arschles enabled auto-merge (squash) October 19, 2021 23:35
@arschles arschles modified the milestones: v0.3.0, v0.2.1 Nov 17, 2021
@arschles arschles removed this from the v0.3.0 milestone Jan 27, 2022
@arschles
Copy link
Collaborator Author

Closing since #225 was marked stale and closed

@arschles arschles closed this Jan 27, 2022
auto-merge was automatically disabled January 27, 2022 19:53

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

@zroubalik zroubalik Awaiting requested review from zroubalik

@ajanth97 ajanth97 Awaiting requested review from ajanth97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have interceptors record what routing table version(s) they are aware of
1 participant
@arschles