PathPrefix-based Routing #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests for this feature are coming in the next few days. I'll rebase with #669 when necessary until it gets merged. |
|
@similark, can you try this version and see if that works as you would expect? Just add set apiVersion: http.keda.sh/v1alpha1
kind: HTTPScaledObject
spec:
pathPrefix: /foo/bar
... |
|
@t0rr3sp3dr0 I actually did the exact same thing and it works great.. I'll test your version today and update here soon. |
|
Let's wait until this is merged for adding new e2e test for this new feature |
|
I have merged #686 |
Closed
3 tasks
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
t0rr3sp3dr0
force-pushed
the
pedrotorres/issue-338
branch
from
5dc6853 to
5889119
Compare
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
t0rr3sp3dr0
force-pushed
the
pedrotorres/issue-338
branch
from
0ed247a to
04f3c1d
Compare
JorTurFer
reviewed
Jun 15, 2023
Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com> Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
t0rr3sp3dr0
force-pushed
the
pedrotorres/issue-338
branch
from
7fcc272 to
8854607
Compare
JorTurFer
approved these changes
Jun 15, 2023
|
Don't we need to update the crd int the chart as well? @JorTurFer @t0rr3sp3dr0 Magnificent work @t0rr3sp3dr0! We'll start using this very soon |
|
Yeah, I forgot that change, let me ship another version with this fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements routing based on a path prefix in addition to the host. A new
.spec.pathPrefixfield was created on HTTPScaledObject. When not specified, the routing behaviour is exactly the same as we had previously with hose-based routing.Depends on: #669
Checklist
README.mddocs/directoryFixes #338