Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timeWindowOffset and lastAvailablePointOffset in datadog scaler #1002

Merged

Conversation

dogzzdogzz
Copy link
Contributor

@dogzzdogzz dogzzdogzz commented Dec 8, 2022

Signed-off-by: Tony Lee dogzzdogzz@gmail.com

Support timeWindowOffset and lastAvailablePointOffset in datadog scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#3906

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
@dogzzdogzz dogzzdogzz requested a review from a team as a code owner December 8, 2022 08:08
@netlify
Copy link

netlify bot commented Dec 8, 2022

Deploy Preview for keda failed.

Name Link
🔨 Latest commit c9cc8c6
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6391dda98d7a0e0008a5a86c

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you opened the PR against 2.6 version, please move this into 2.9.

content/docs/2.6/scalers/datadog.md Outdated Show resolved Hide resolved
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
@dogzzdogzz dogzzdogzz requested a review from zroubalik December 8, 2022 12:52
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks

@zroubalik zroubalik merged commit 2beefe8 into kedacore:main Dec 8, 2022
tomkerkhove added a commit that referenced this pull request Dec 9, 2022
tomkerkhove added a commit that referenced this pull request Dec 9, 2022
…dog scaler #1002

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@JorTurFer JorTurFer mentioned this pull request Jan 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datadog scaler] Scaler returns fillValue if the last data point of query is null
2 participants