Add Doc changes for enableTls and saslAuthType for Kafka Scaler ScaledObject
#1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
5 tasks
JorTurFer
requested changes
Mar 6, 2023
|
This is outdated as well so let's give @dttung2905 some time to update, let us know when you are ready @dttung2905. |
6 tasks
dttung2905
changed the title
enableTls and saslAuthType for Kafka Scaler ScaledObject
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
dttung2905
force-pushed
the
add-kafka-tls-doc
branch
from
913cecb to
4891356
Compare
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
Hi team, |
JorTurFer
reviewed
Mar 9, 2023
|
|
||
| **Credential based authentication:** | ||
|
|
||
| **SASL:** | ||
|
|
||
| - `sasl` - Kafka SASL auth mode. (Values: `plaintext`, `scram_sha256`, `scram_sha512`, `oauthbearer` or `none`, Default: `none`, Optional) | ||
| - `sasl` / `saslAuthType` - Kafka SASL auth mode. (Values: `plaintext`, `scram_sha256`, `scram_sha512`, `oauthbearer` or `none`, Default: `none`, Optional) |
There was a problem hiding this comment.
I think that we can reuse the same key as it can be recovered from both places
There was a problem hiding this comment.
Yes thats what I have in mind too as I start writing the doc 😂. Should be good to reuse the same key to avoid further confusion
|
|
||
| **TLS:** | ||
|
|
||
| - `tls` - To enable SSL auth for Kafka, set this to `enable`. If not set, TLS for Kafka is not used. (Values: `enable`, `disable`, Default: `disable`, Optional) | ||
| - `tls` / `enableTls` - To enable SSL auth for Kafka, set this to `enable` / `disable`. If not set, TLS for Kafka is not used. (Values: `enable` / `true`, `disable` / `false`, Default: `disable` / `false`, Optional) |
There was a problem hiding this comment.
I think that we can reuse the same key as it can be recovered from both places
zroubalik
reviewed
Mar 9, 2023
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
zroubalik
requested changes
Mar 9, 2023
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
zroubalik
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi KEDA core dev team,
Please advise me on whether this is the correct place to add changes to the doc, given that version 2.9.0 was released just the day before this MR was made. Thanks alot !
Checklist
Fixes #