Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keda_scaled_object_paused to the docs #1111

Closed

Conversation

eladmotola
Copy link
Contributor

@eladmotola eladmotola commented Apr 22, 2023

related to kedacore/keda#4446

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Signed-off-by: Elad Motola <eladmotola95@gmail.com>
@eladmotola eladmotola requested a review from a team as a code owner April 22, 2023 08:36
@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit b659487
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6443cf6292c42200083ff11f
😎 Deploy Preview https://deploy-preview-1111--keda.netlify.app/docs/2.11/operate/prometheus
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

content/docs/2.11/operate/prometheus.md Outdated Show resolved Hide resolved
@eladmotola eladmotola changed the title add keda_scaled_object_pause to the docs add keda_scaled_object_paused to the docs Apr 22, 2023
Signed-off-by: Elad Motola <eladmotola95@gmail.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geoffrey1330 Please update this pr:

  • add opentelemetry docs
  • move to version 2.13

@@ -16,6 +16,7 @@ The KEDA Operator exposes Prometheus metrics which can be scraped on port `8080`
- `keda_scaler_errors` - The number of errors that have occurred for each scaler.
- `keda_scaler_errors_total` - The total number of errors encountered for all scalers.
- `keda_scaled_object_errors` - The number of errors that have occurred for each ScaledObejct.
- `keda_scaled_object_paused` - The number of paused scaledObject (using the annotation detailed [here](https://keda.sh/docs/latest/concepts/scaling-deployments/#pause-autoscaling))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not number of paused scaledobjects, but it marks whether the SO is paused or not.

Move this to line 14, so it is next to activity

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I will do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geoffrey1330 please fix this, so we can go ahead and merge the feature

@zroubalik
Copy link
Member

replaced by #1249

@zroubalik zroubalik closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants