Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: revert deprecation of metricName for Azure Monitor scaler #1158

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

lsolovey
Copy link
Contributor

Revert the deprecation of metricName field in the Azure Monitor scaler (originally deprecated in #1074).

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1152

Signed-off-by: Leonid Solovey <38634160+lsolovey@users.noreply.github.com>
@lsolovey lsolovey requested a review from a team as a code owner June 18, 2023 04:03
@netlify
Copy link

netlify bot commented Jun 18, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit bded316
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/64927b112f8b2c0008de9b5c
😎 Deploy Preview https://deploy-preview-1158--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@JorTurFer
Copy link
Member

Nice!
Could you update the code as well to remove the deprecation message in case of this scaler?

@lsolovey
Copy link
Contributor Author

Nice! Could you update the code as well to remove the deprecation message in case of this scaler?

@JorTurFer Yes, I will be sending a PR for that as well.

@lsolovey
Copy link
Contributor Author

@JorTurFer I've just opened a separate PR for the code changes: kedacore/keda#4713

@JorTurFer JorTurFer merged commit e5d61a8 into kedacore:main Jun 21, 2023
@lsolovey lsolovey deleted the azure-monitor-metric-name branch June 22, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why Azure Monitor Scaler metricName is deprecated
2 participants