Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix config for Experimental Kafka Scaler #1229

Merged
merged 1 commit into from
Sep 25, 2023
Merged

chore: fix config for Experimental Kafka Scaler #1229

merged 1 commit into from
Sep 25, 2023

Conversation

zroubalik
Copy link
Member

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates #1187

@zroubalik zroubalik requested a review from a team as a code owner September 25, 2023 12:25
@netlify
Copy link

netlify bot commented Sep 25, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 0fc60d1
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65117e07df4c010008f3f04b
😎 Deploy Preview https://deploy-preview-1229--keda.netlify.app/docs/2.12/scalers/apache-kafka-go
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@zroubalik
chore: fix config for Experimental Kafka Scaler
0fc60d1 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik
Copy link
Member Author

You can probably also add about gssapi / kerberos. This I will take a dig at later on.

@sansmoraxz could you please add code suggestion here in the docs?

@zroubalik zroubalik merged commit e03ee09 into kedacore:main Sep 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansmoraxz sansmoraxz sansmoraxz left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zroubalik @sansmoraxz @JorTurFer