docs(scalers): Update cpu and memory scaler docs for validating requests/limits from LimitRange
#1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for cpu & memory scalers for KEDA controller checking for default limits and requests in LimitRange, for Container type, in the same namespace, for validation when the container resources are not specified in the pod spec. Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
When using `cpu` or `memory` scalers, the KEDA controller checks whether `requests` or `limits` are specified for the container resources. The `requests` are specified in the docs, but the `limits` are missing. This change updates the `cpu` and `memory` scaler docs to mention the `limits` that are also validated. Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
wozniakjan
reviewed
Jan 17, 2024
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
zroubalik
approved these changes
Jan 18, 2024
|
Thanks @zroubalik :-) |
Bhargav-InfraCloud
deleted the
br_update_cpu_and_memory_scaler_docs_for_picking_limits_from_limitrange
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Update for cpu & memory scalers for KEDA controller checking for default limits and requests in LimitRange, for Container type, in the same namespace, for validation when the container resources are not specified in the pod spec.
Also, the following is updated:
When using
cpuormemoryscalers, the KEDA controller checks whetherrequestsorlimitsare specified for the container resources. Therequestsare specified in the docs, but thelimitsare missing. This change updates thecpuandmemoryscaler docs to mention thelimitsthat are also validated.Checklist
Relates to issue kedacore/keda#5348
Relates to PR kedacore/keda#5377