Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for WATCH_NAMESPACE #1357

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Add docs for WATCH_NAMESPACE #1357

merged 2 commits into from
Apr 10, 2024

Conversation

jkremser
Copy link
Contributor

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#5670

@jkremser
Add docs for WATCH_NAMESPACE
be1e9b7 
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@jkremser jkremser requested a review from a team as a code owner April 10, 2024 10:39
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Apr 10, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 8ea6636
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6616883d7888b1000826e066
😎 Deploy Preview https://deploy-preview-1357--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jkremser jkremser mentioned this pull request Apr 10, 2024
Merged
@jkremser
add example
8ea6636 
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
zroubalik
zroubalik approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 63bcd17 into kedacore:main Apr 10, 2024
8 checks passed
@jkremser jkremser deleted the watch-ns branch April 10, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple namespaces passed to WATCH_NAMESPACE
2 participants
@jkremser @zroubalik