Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update postgres docs for nulls and coalesce #1393

Merged
merged 1 commit into from
May 20, 2024

Conversation

robpickerill
Copy link
Contributor

@robpickerill robpickerill commented May 17, 2024

Updates Postgres scaler docs to add a note about handling nulls in the query.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#5686 for postgres, will present separate PRs for other RDBMS scalers

Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
@robpickerill robpickerill requested a review from a team as a code owner May 17, 2024 11:13
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented May 17, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit bfdb8ec
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66473bf00eccce0008e953ce
😎 Deploy Preview https://deploy-preview-1393--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zroubalik zroubalik merged commit 461a16d into kedacore:main May 20, 2024
8 of 9 checks passed
rxg8255 pushed a commit to rxg8255/keda-docs that referenced this pull request Jun 27, 2024
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
shubhusion pushed a commit to shubhusion/keda-docs that referenced this pull request Jun 28, 2024
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres Scaler fails when the postgresql query returns NULL value
2 participants