Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: version faq docs #1416

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Feat: version faq docs #1416

merged 2 commits into from
Jul 4, 2024

Conversation

thisisobate
Copy link
Contributor

This PR introduces versioning for FAQ.

Versions affected

v2.14 and upwards

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #935

@thisisobate
Feat: version faq docs
2dbdfab 
Signed-off-by: thisisobate <obasiuche62@gmail.com>
@thisisobate thisisobate requested a review from a team as a code owner June 28, 2024 19:02
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 43cabd8
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66854aecadc549000894b7fa
😎 Deploy Preview https://deploy-preview-1416--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thisisobate thisisobate marked this pull request as draft June 28, 2024 19:03
@thisisobate thisisobate marked this pull request as ready for review June 28, 2024 19:12
tomkerkhove
tomkerkhove reviewed Jul 1, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
davogen
davogen reviewed Jul 1, 2024
View reviewed changes
Copy link

@davogen davogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, I am new to KEDA and this is something that was strange to me in the FAQ section (due to a policy we need to use an older version of KEDA)

@thisisobate
chore: start sentence with capital letter
43cabd8 
Signed-off-by: thisisobate <obasiuche62@gmail.com>
@thisisobate thisisobate requested a review from tomkerkhove July 3, 2024 12:58
@tomkerkhove tomkerkhove merged commit a66ae1f into kedacore:main Jul 4, 2024
8 checks passed
@tomkerkhove
Copy link
Member

Thank you!

SpiritZhou pushed a commit to SpiritZhou/keda-docs that referenced this pull request Jul 11, 2024
@thisisobate @SpiritZhou
Feat: version faq docs (kedacore#1416)
8dc20a4
shubhusion pushed a commit to shubhusion/keda-docs that referenced this pull request Aug 5, 2024
@thisisobate @shubhusion
Feat: version faq docs (kedacore#1416)
704e541 
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davogen davogen davogen left review comments

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide versioning for our FAQ
3 participants
@thisisobate @tomkerkhove @davogen