Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No authentication required for Kafka #19

Merged
merged 1 commit into from
Nov 14, 2019
Merged

No authentication required for Kafka #19

merged 1 commit into from
Nov 14, 2019

Conversation

tomkerkhove
Copy link
Member

@jeffhollan jeffhollan merged commit ea7289c into kedacore:master Nov 14, 2019
@abhirockzz
Copy link
Contributor

abhirockzz commented Nov 15, 2019 •
edited
Loading

Is there a specific reason? Just curious. Kafka does support SASL and the sarama go client used in the Kafka scaler could be used to support PLAIN SASL mechanism

@tomkerkhove
Copy link
Member Author

These docs are just what is there in KEDA today, we've briefly discussed this yesterday and will probably improve this but nobody has asked for this yet.

If you need this, feel free to open a feature request!

@tomkerkhove tomkerkhove deleted the kafka-auth branch November 15, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffhollan jeffhollan jeffhollan approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Kafka trigger to use new authentication approach
3 participants
@tomkerkhove @abhirockzz @jeffhollan