[v2] Update scaled job #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsuyoshiUshio
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
TsuyoshiUshio
force-pushed
the
tsushi/scaledjob
branch
from
81efe96
to
cb996ae
Compare
tomkerkhove
reviewed
Aug 10, 2020
|
It would be nice, if you can provide Details section in the similar fashion that it is for ScaledObject? Add a short paragraph describing the properties. |
|
Thank you for the review, @tomkerkhove and @zroubalik I'm surely update this PR. I didn't noticed the section. |
TsuyoshiUshio
force-pushed
the
tsushi/scaledjob
branch
from
35f8785
to
525c004
Compare
|
I update the documentation. I added
on the scaled job. Could you have a look and review it? |
tomkerkhove
reviewed
Aug 13, 2020
Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
TsuyoshiUshio
force-pushed
the
tsushi/scaledjob
branch
from
ac6bdc6
to
bef97c5
Compare
|
Hi @tomkerkhove |
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Scaled Job according to the logic.
successfulJobsHistoryLimitandfailedJobsHistoryLimitfor removing completing/failed jobs.MinReplicaCountandCooldownPeriodthat is not fit for the ScaledJob.Reference
kedacore/keda#959
kedacore/keda#956