Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for known GKE issue detailed in issue 515 #237

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

thefirstofthe300
Copy link
Contributor

@thefirstofthe300 thefirstofthe300 commented Aug 24, 2020

Addresses documentation requested in kedacore/keda#515 (comment)

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added a few nits to improve the rendered docs.

content/troubleshooting/gke-external-metrics.md Outdated Show resolved Hide resolved
content/troubleshooting/gke-external-metrics.md Outdated Show resolved Hide resolved
content/troubleshooting/gke-external-metrics.md Outdated Show resolved Hide resolved
content/troubleshooting/gke-external-metrics.md Outdated Show resolved Hide resolved
Signed-off-by: Danny Seymour <dseymour@taos.com>
@ahmelsayed ahmelsayed merged commit 7e87b16 into kedacore:master Aug 25, 2020
@tomkerkhove
Copy link
Member

Thanks @thefirstofthe300 !

@thefirstofthe300 thefirstofthe300 deleted the ds/issue-515 branch August 25, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants