add cpu/memory scaler #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silenceper
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
4 tasks
tomkerkhove
approved these changes
Oct 3, 2020
There was a problem hiding this comment.
LGTM, nice and simple.
Will leave it up to @zroubalik to merge when implementation is done since I'm out next week.
Signed-off-by: silenceper <silenceper@gmail.com>
silenceper
force-pushed
the
f-resource-scaler
branch
from
0e1ae26
to
ef2d770
Compare
|
We should be vocal about the limitations of these scalers with ScaledJobs. |
Signed-off-by: silenceper <silenceper@gmail.com>
|
LGTM! |
zzxwill
reviewed
Oct 13, 2020
content/docs/2.0/scalers/cpu.md
Outdated
| - type: cpu | ||
| metadata: | ||
| type: Utilization | ||
| type: "50" |
There was a problem hiding this comment.
Suggested change
| type: "50" | |
| value: 50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: silenceper silenceper@gmail.com
Relates to kedacore/keda#1215
Relates to kedacore/keda#1183