Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs for how to override the default HTTP client timeout #324

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

arschles
Copy link
Contributor

@arschles arschles commented Dec 10, 2020

kedacore/keda#1251

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing that would need to change is move this to v2.1 docs please

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik
Copy link
Member

@arschles one more small nit, could you please move this to 2.1 docs? ie. content/docs/2.1/operate.md

From 2.0

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
Copy link
Contributor Author

@zroubalik sorry for the delay - done 😄

@zroubalik zroubalik merged commit 80b5404 into kedacore:master Jan 19, 2021
@arschles arschles deleted the httpclient branch March 29, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants