Add OpenStack Swift scaler documentation #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdominguite
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
pdominguite
force-pushed
the
add_swift_scaler_documentation
branch
from
c235cc4
to
3fda91f
Compare
4 tasks
tomkerkhove
reviewed
Jan 1, 2021
tomkerkhove
reviewed
Jan 1, 2021
zroubalik
reviewed
Jan 4, 2021
|
|
||
| ```yaml | ||
| triggers: | ||
| - type: swift |
There was a problem hiding this comment.
Not sure about the name of the scaler, maybeopenstack-swift is more appropriate?
There was a problem hiding this comment.
Makes sense since other scalers use the same standard (azure-queue, azure-blob, redis-streams).
There was a problem hiding this comment.
Yeah, thanks. Could you please do the same change in the code? (where relevant of course)
There was a problem hiding this comment.
Sure! I'm on it 😄
There was a problem hiding this comment.
Scaler name in documentation updated by 2f61e83.
tomkerkhove
approved these changes
Jan 5, 2021
Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br> * Update example section Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br> * Change scaler name to openstack-swift Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br> * Fix typos Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br> * Add more timeout details Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>
pdominguite
force-pushed
the
add_swift_scaler_documentation
branch
from
751f063
to
204acc1
Compare
zroubalik
approved these changes
Jan 8, 2021
zroubalik
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pedro Dominguite p.dominguite@sidi.org.br
This PR adds documentation for OpenStack Swift scaler.
PR for the scaler can be found at kedacore/keda#1462.
Relates to kedacore/keda#1342.