Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update V1 Install docs #395

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Update V1 Install docs #395

merged 3 commits into from
Mar 8, 2021

Conversation

pragnagopa
Copy link
Contributor

@pragnagopa
Copy link
Contributor Author

cc @tomkerkhove

tomkerkhove
tomkerkhove reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a small suggestion and was wondering if you would be able to do the same for v1.5?

pragnagopa and others added 3 commits March 8, 2021 07:21
@pragnagopa
Update V1 Install docs
ad1626e 
Signed-off-by: Pragna Gopa <pgopa@microsoft.com>
@pragnagopa @tomkerkhove
Update content/docs/1.4/deploy.md
370307d 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Pragna Gopa <pgopa@microsoft.com>
@pragnagopa
Update 1.5.0 docs
40b26fd 
Signed-off-by: Pragna Gopa <pgopa@microsoft.com>
tomkerkhove
tomkerkhove approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomkerkhove tomkerkhove merged commit ce5aa9a into kedacore:master Mar 8, 2021
Rodolfodc pushed a commit to sidilabs/keda-docs that referenced this pull request Mar 26, 2021
@pragnagopa @tomkerkhove @Rodolfodc
Update V1 Install docs (kedacore#395)
c520e78 
* Update V1 Install docs

Signed-off-by: Pragna Gopa <pgopa@microsoft.com>

* Update content/docs/1.4/deploy.md

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Pragna Gopa <pgopa@microsoft.com>

* Update 1.5.0 docs

Signed-off-by: Pragna Gopa <pgopa@microsoft.com>

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@jeffhollan jeffhollan Awaiting requested review from jeffhollan

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pragnagopa @tomkerkhove