-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce: rolloutStrategy #563
Conversation
Signed-off-by: etamarw <etamarw@wix.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Great feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add rolloutStrategy
entry to the ScaledJob Spec
section at the begging of the page?
somewhere around line 43 (after maxReplicaCoutn
and before scalingStrategy
).
Thanks!
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: etamarw <etamarw@wix.com>
247dbc2
to
cec5a9d
Compare
Signed-off-by: etamarw <etamarw@wix.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @etamarw !
Signed-off-by: etamarw etamarw@wix.com
add rolloutStrategy to the scaledjob docs.
Checklist