-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the support for different metric types #657
Conversation
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a few notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left a small suggestion, but I don't think that's strictly necessary for this PR to be merged.
b060d67
to
9e2e59e
Compare
Signed-off-by: amirschw <24677563+amirschw@users.noreply.github.com>
9e2e59e
to
da5dc85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the example
Signed-off-by: amirschw <24677563+amirschw@users.noreply.github.com>
Signed-off-by: amirschw <24677563+amirschw@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits :)
@amirschw FYI
Signed-off-by: amirschw <24677563+amirschw@users.noreply.github.com>
Related PR in the keda repo: kedacore/keda#2309.
Checklist
Signed-off-by: amirschw 24677563+amirschw@users.noreply.github.com
Relates to kedacore/keda#2030