Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for the new GCP storage scaler #660

Merged
merged 7 commits into from
Mar 14, 2022

Conversation

RamCohen
Copy link
Contributor

@RamCohen RamCohen commented Feb 16, 2022

Added documentation for the new GCP storage scaler

Signed-off-by: Ram Cohen ram.cohen@gmail.com

Relates to kedacore/keda#2628

Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: 291f5b1

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/622074efd735600008917491

😎 Browse the preview: https://deploy-preview-660--keda.netlify.app/docs/2.7/scalers/gcp-storage

content/docs/2.7/scalers/gcp-storage.md Show resolved Hide resolved
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few alignments - Thank you!

content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Waiting for feature to be merged

@tomkerkhove
Copy link
Member

@RamCohen Can you fix the DCO issues please? You can learn more in our contribution guide.

RamCohen and others added 3 commits February 21, 2022 11:44
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
RamCohen added 2 commits March 1, 2022 11:57
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/gcp-storage.md Outdated Show resolved Hide resolved
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
@RamCohen RamCohen requested a review from JorTurFer as a code owner March 3, 2022 07:57
@RamCohen
Copy link
Contributor Author

ping to merge

@JorTurFer JorTurFer merged commit 1871814 into kedacore:main Mar 14, 2022
@JorTurFer
Copy link
Member

Thanks a ton for this contribution!

samueleresca pushed a commit to samueleresca/keda-docs that referenced this pull request Mar 17, 2022
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants