-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for the new GCP storage scaler #660
Conversation
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
✔️ Deploy Preview for keda ready! 🔨 Explore the source changes: 291f5b1 🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/622074efd735600008917491 😎 Browse the preview: https://deploy-preview-660--keda.netlify.app/docs/2.7/scalers/gcp-storage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few alignments - Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Waiting for feature to be merged
@RamCohen Can you fix the DCO issues please? You can learn more in our contribution guide. |
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
46faff8
to
b43dea8
Compare
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
ping to merge |
Thanks a ton for this contribution! |
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Added documentation for the new GCP storage scaler
Signed-off-by: Ram Cohen ram.cohen@gmail.com
Relates to kedacore/keda#2628