Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify datadog rate limit #682

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

arapulido
Copy link
Contributor

Selecting a small time window for Datadog, can cause returning an empty series.
Trying to discourage this by avoiding reducing the window in the example in the docs.

Also, added some clarification about Datadog's rate limits

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
@netlify
Copy link

netlify bot commented Mar 1, 2022

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: 434a8cb

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/6221eb2837dcf300082fc94a

😎 Browse the preview: https://deploy-preview-682--keda.netlify.app

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update v2.7 doc as well please?

content/docs/2.6/scalers/datadog.md Show resolved Hide resolved
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
@arapulido
Copy link
Contributor Author

Can you update v2.7 doc as well please?
done. thanks!

@JorTurFer
Copy link
Member

Thanks for the improvement!

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arapulido!

@tomkerkhove tomkerkhove merged commit e738edb into kedacore:main Mar 4, 2022
samueleresca pushed a commit to samueleresca/keda-docs that referenced this pull request Mar 17, 2022
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants