-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActivationValue for RabbitMQ scaler #733
ActivationValue for RabbitMQ scaler #733
Conversation
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a generic section on activation threshold
in the docs. Where we describe the behavior (current and the new). And here reference this doc.
WDYT? @kedacore/keda-contributors
I like it, since, is going to be a generic concept for all scalers. |
+1 to a specific section |
What do you think about add the section in a different PR/ticket. Since this is only affecting a single scaler. So we don't block this PR and also because not sure where this new section should be placed. |
A new PR is fine, but this general section should be added before this feature lands. @kedacore/keda-contributors ideas on the docs section? |
Maybe we can explain it under Scaling Deployments, StatefulSets & Custom Resources due to this only applies to ScaledObjects. |
Signed-off-by: Alejandro Dominguez <adborroto90@gmail.com>
Signed-off-by: Alejandro Dominguez <adborroto90@gmail.com>
b50aef6
to
a3b4173
Compare
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
a3b4173
to
86aed8f
Compare
Signed-off-by: Alejandro Dominguez adborroto90@gmail.com
Adding activation threshold (minMetricValue) for Rabbitmq.
Feature PR: #2831
Checklist
Fixes #