Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivationValue for RabbitMQ scaler #733

Merged

Conversation

adborroto
Copy link
Contributor

@adborroto adborroto commented Mar 27, 2022

Signed-off-by: Alejandro Dominguez adborroto90@gmail.com

Adding activation threshold (minMetricValue) for Rabbitmq.

Feature PR: #2831

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@netlify
Copy link

netlify bot commented Mar 27, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 86aed8f
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/62ea4bab6563440008836696
😎 Deploy Preview https://deploy-preview-733--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@adborroto adborroto changed the title MinMetricValue for RabbitMQ scaler ActionvationValue for RabbitMQ scaler Mar 31, 2022
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a generic section on activation threshold in the docs. Where we describe the behavior (current and the new). And here reference this doc.
WDYT? @kedacore/keda-contributors

@zroubalik zroubalik changed the title ActionvationValue for RabbitMQ scaler ActivationValue for RabbitMQ scaler Apr 1, 2022
@adborroto
Copy link
Contributor Author

I think we should have a generic section on activation threshold in the docs. Where we describe the behavior (current and the new). And here reference this doc. WDYT? @kedacore/keda-contributors

I like it, since, is going to be a generic concept for all scalers.

@JorTurFer
Copy link
Member

+1 to a specific section

@adborroto
Copy link
Contributor Author

I think we should have a generic section on activation threshold in the docs. Where we describe the behavior (current and the new). And here reference this doc. WDYT? @kedacore/keda-contributors

What do you think about add the section in a different PR/ticket. Since this is only affecting a single scaler. So we don't block this PR and also because not sure where this new section should be placed.

@zroubalik
Copy link
Member

A new PR is fine, but this general section should be added before this feature lands.

@kedacore/keda-contributors ideas on the docs section?

@JorTurFer
Copy link
Member

Maybe we can explain it under Scaling Deployments, StatefulSets & Custom Resources due to this only applies to ScaledObjects.
Something like "Differences between activation and scaling"

Signed-off-by: Alejandro Dominguez <adborroto90@gmail.com>
Signed-off-by: Alejandro Dominguez <adborroto90@gmail.com>
@JorTurFer JorTurFer force-pushed the feature/update_rabbitmq_minMetricValue branch from b50aef6 to a3b4173 Compare August 3, 2022 10:18
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer force-pushed the feature/update_rabbitmq_minMetricValue branch from a3b4173 to 86aed8f Compare August 3, 2022 10:19
@JorTurFer JorTurFer merged commit bc91831 into kedacore:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants