-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Permission segregation for Azure AD Pod & Workload Identity. #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vighnesh Shenoy <vighneshq@gmail.com>
v-shenoy
requested review from
jeffhollan,
ahmelsayed,
tomkerkhove,
zroubalik and
JorTurFer
as code owners
June 21, 2022 21:20
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Merged
5 tasks
tomkerkhove
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few suggestions + tweaks
Signed-off-by: Vighnesh Shenoy <vighneshq@gmail.com>
tomkerkhove
reviewed
Jun 22, 2022
tomkerkhove
reviewed
Jun 22, 2022
Signed-off-by: Vighnesh Shenoy <vighneshq@gmail.com>
tomkerkhove
approved these changes
Jun 22, 2022
zroubalik
approved these changes
Jun 22, 2022
JorTurFer
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vighnesh Shenoy vighneshq@gmail.com
kedacore/keda#3216
Provide a description of what has been changed
Checklist
Relates to kedacore/keda#2656