Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce activationThreshold/minMetricValue for GCP scalers #831

Merged
merged 2 commits into from
Jul 24, 2022

Conversation

RamCohen
Copy link
Contributor

Signed-off-by: Ram Cohen ram.cohen@gmail.com

Related to kedacore/keda#2800
Related to kedacore/keda#3414

Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
@netlify
Copy link

netlify bot commented Jul 21, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 5ffa963
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/62dcefb8148ec20009396c9b
😎 Deploy Preview https://deploy-preview-831--keda.netlify.app/docs/2.8/scalers/gcp-pub-sub
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only pending changes from core

Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
@JorTurFer JorTurFer merged commit f8138bd into kedacore:main Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants