Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CouchDB scaler docs #967

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Conversation

26tanishabanik
Copy link
Contributor

@26tanishabanik 26tanishabanik commented Nov 1, 2022

Signed-off-by: 26tanishabanik 26tanishabanik@gmail.com

Provide a description of what has been changed

  • Adds CouchDB scaler docs to v2.9

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#3746
Relates to kedacore/keda#3804

Signed-off-by: 26tanishabanik <26tanishabanik@gmail.com>
@26tanishabanik 26tanishabanik requested a review from a team as a code owner November 1, 2022 15:00
@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 6759246
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6391bc725ea5dc00085a2b85
😎 Deploy Preview https://deploy-preview-967--keda.netlify.app/docs/2.9/scalers/couchdb
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@26tanishabanik 26tanishabanik changed the title added couchdb docs Adds CouchDB scaler docs Nov 1, 2022
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response...
I can see in the code that there is another parameter named connectionString not documented here. We should also put in Authentication Parameters section all the parameter which can be got from authentication, I see in the code that host, port and connectionString are recovered too from there

content/docs/2.9/scalers/couchdb.md Outdated Show resolved Hide resolved
content/docs/2.9/scalers/couchdb.md Outdated Show resolved Hide resolved
content/docs/2.9/scalers/couchdb.md Outdated Show resolved Hide resolved
Signed-off-by: 26tanishabanik <26tanishabanik@gmail.com>
content/docs/2.9/scalers/couchdb.md Outdated Show resolved Hide resolved
Signed-off-by: 26tanishabanik <26tanishabanik@gmail.com>
@zroubalik zroubalik merged commit 80f8168 into kedacore:main Dec 8, 2022
mohite-abhi added a commit to mohite-abhi/keda-docs that referenced this pull request Jan 10, 2023
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
JorTurFer added a commit that referenced this pull request Jan 17, 2023
* Add tls auth doc for rabbitmq scaler (#967)

Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>

* Update content/docs/2.10/scalers/rabbitmq-queue.md

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Abhishek Mohite <abhishekmohite421@gmail.com>

Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <abhishekmohite421@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants