Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documents to reference float64 for GCP pub sub and stackdriver #995

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

octothorped
Copy link
Contributor

@octothorped octothorped commented Dec 2, 2022

Signed-off-by: Eric Takemoto 24865872+octothorped@users.noreply.github.com

Documentation of kedacore/keda#3788. targetValue and activationTargetValue can now be floats. The changes here are based on the Prometheus scalar documentation for its float values.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#3777

Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com>
@octothorped octothorped requested a review from a team as a code owner December 2, 2022 23:50
@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit c670cff
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/638e288e3f52f8000818f7bf
😎 Deploy Preview https://deploy-preview-995--keda.netlify.app/docs/2.9/scalers/gcp-pub-sub
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the example values in yaml file for pub/sub?

Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com>
@octothorped
Copy link
Contributor Author

Could you also update the example values in yaml file for pub/sub?

Updated the pub/sub yaml examples values to also be float values.

@JorTurFer JorTurFer merged commit bea2cf8 into kedacore:main Dec 5, 2022
@JorTurFer JorTurFer mentioned this pull request Jan 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants