ScaledJob: support metadata labels in Job template (#1686)

CHANGELOG.md

@@ -41,6 +41,7 @@
 - Add `publishRate` trigger to RabbitMQ scaler ([#1653](https://github.com/kedacore/keda/pull/1653))
 - AWS SQS Scaler: Add Visible + NotVisible messages for scaling considerations ([#1664](https://github.com/kedacore/keda/pull/1664))
 - Fixing behavior on ScaledJob with incorrect External Scaler ([#1672](https://github.com/kedacore/keda/pull/1672))
+- ScaledJob: support metadata labels in Job template ([#1686](https://github.com/kedacore/keda/pull/1686))
 
 ### Breaking Changes
 

config/crd/kustomization.yaml

@@ -8,8 +8,7 @@ resources:
 - bases/keda.sh_clustertriggerauthentications.yaml
 # +kubebuilder:scaffold:crdkustomizeresource
 
-## ScaledJob CRD needs to be patched because of an issue with required properties
-## https://github.com/kedacore/keda/issues/927
+## ScaledJob CRD needs to be patched because for some usecases (details in the patch file)
 patchesJson6902:
 - target:
     version: v1

config/crd/patches/scaledjob_patch.yaml

@@ -1,4 +1,6 @@
 ---
+## needs to be patched because of an issue with required properties in order to be able to deploy on k8s 1.18+
+## https://github.com/kedacore/keda/issues/927
 - op: add
   path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/jobTargetRef/properties/template/properties/spec/properties/containers/items/properties/ports/items/required/-
   value: protocol
@@ -10,3 +12,9 @@
 - op: add
   path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/jobTargetRef/properties/template/properties/spec/properties/initContainers/items/properties/ports/items/required/-
   value: protocol
+
+## needs to be patched because of an issue with controller-gen, which is not including anything in metadata from nested contructs
+## https://github.com/kedacore/keda/issues/1311
+- op: add
+  path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/jobTargetRef/properties/template/properties/metadata/x-kubernetes-preserve-unknown-fields
+  value: true