Skip to content

Commit

Permalink
replace namepsace by exported_namespace in keda-dashboard
Browse files Browse the repository at this point in the history
Signed-off-by: Shamil Ganiev <ganiev@pm.me>
  • Loading branch information
ganievs committed May 18, 2023
1 parent ac600e9 commit 6923a4f
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 35 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
- **NATS Jetstream Scaler**: Fix compatibility if node is not advertised ([#4524](https://github.com/kedacore/keda/issues/4524))
- **Prometheus Metrics**: Create e2e tests for all exposed Prometheus metrics ([#4127](https://github.com/kedacore/keda/issues/4127))
- **Grafana Dashboard**: Fix HPA metrics panel to use range instead of instant ([#4513](https://github.com/kedacore/keda/pull/4513))
- **Grafana Dashboard**: Fix HPA metrics panel by replacing $namepsace to $exported_namespace due to label conflict ([#4539](https://github.com/kedacore/keda/pull/4539))

### Deprecations

Expand Down
70 changes: 35 additions & 35 deletions config/grafana/keda-dashboard.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"target": {
"limit": 100,
"matchAny": false,
"tags": [],
"tags": [ ],
"type": "dashboard"
},
"type": "dashboard"
Expand All @@ -26,7 +26,7 @@
"fiscalYearStartMonth": 0,
"graphTooltip": 0,
"id": 9794,
"links": [],
"links": [ ],
"liveNow": false,
"panels": [
{
Expand All @@ -38,7 +38,7 @@
"y": 0
},
"id": 8,
"panels": [],
"panels": [ ],
"title": "Metric Server",
"type": "row"
},
Expand Down Expand Up @@ -81,7 +81,7 @@
"mode": "off"
}
},
"mappings": [],
"mappings": [ ],
"thresholds": {
"mode": "absolute",
"steps": [
Expand Down Expand Up @@ -154,7 +154,7 @@
"id": 4,
"options": {
"legend": {
"calcs": [],
"calcs": [ ],
"displayMode": "list",
"placement": "bottom",
"showLegend": true
Expand Down Expand Up @@ -219,7 +219,7 @@
"mode": "off"
}
},
"mappings": [],
"mappings": [ ],
"thresholds": {
"mode": "absolute",
"steps": [
Expand Down Expand Up @@ -292,7 +292,7 @@
"id": 3,
"options": {
"legend": {
"calcs": [],
"calcs": [ ],
"displayMode": "list",
"placement": "bottom",
"showLegend": true
Expand All @@ -309,7 +309,7 @@
"uid": "${datasource}"
},
"editorMode": "code",
"expr": "sum by(scaler) (rate(keda_scaler_errors{namespace=~\"$namespace\", scaledObject=~\"$scaledObject\", scaler=~\"$scaler\"}[5m]))",
"expr": "sum by(scaler) (rate(keda_scaler_errors{exported_namespace=~\"$namespace\", scaledObject=~\"$scaledObject\", scaler=~\"$scaler\"}[5m]))",
"legendFormat": "{{ scaler }}",
"range": true,
"refId": "A"
Expand Down Expand Up @@ -357,7 +357,7 @@
"mode": "off"
}
},
"mappings": [],
"mappings": [ ],
"thresholds": {
"mode": "absolute",
"steps": [
Expand Down Expand Up @@ -400,7 +400,7 @@
"id": 2,
"options": {
"legend": {
"calcs": [],
"calcs": [ ],
"displayMode": "list",
"placement": "bottom",
"showLegend": true
Expand All @@ -417,7 +417,7 @@
"uid": "${datasource}"
},
"editorMode": "code",
"expr": "sum by(scaledObject) (rate(keda_scaled_object_errors{namespace=~\"$namespace\", scaledObject=~\"$scaledObject\"}[5m]))",
"expr": "sum by(scaledObject) (rate(keda_scaled_object_errors{exported_namespace=~\"$namespace\", scaledObject=~\"$scaledObject\"}[5m]))",
"legendFormat": "{{ scaledObject }}",
"range": true,
"refId": "A"
Expand Down Expand Up @@ -465,7 +465,7 @@
"mode": "off"
}
},
"mappings": [],
"mappings": [ ],
"thresholds": {
"mode": "absolute",
"steps": [
Expand Down Expand Up @@ -508,7 +508,7 @@
"id": 5,
"options": {
"legend": {
"calcs": [],
"calcs": [ ],
"displayMode": "list",
"placement": "bottom",
"showLegend": true
Expand All @@ -525,7 +525,7 @@
"uid": "${datasource}"
},
"editorMode": "code",
"expr": "sum by(metric) (rate(keda_scaler_metrics_value{namespace=~\"$namespace\", metric=~\"$metric\"}[5m]))",
"expr": "sum by(metric) (rate(keda_scaler_metrics_value{exported_namespace=~\"$namespace\", metric=~\"$metric\"}[5m]))",
"legendFormat": "{{ metric }}",
"range": true,
"refId": "A"
Expand All @@ -543,7 +543,7 @@
"y": 19
},
"id": 10,
"panels": [],
"panels": [ ],
"title": "Scale Target",
"type": "row"
},
Expand Down Expand Up @@ -589,7 +589,7 @@
},
"unit": "none"
},
"overrides": []
"overrides": [ ]
},
"gridPos": {
"h": 10,
Expand Down Expand Up @@ -652,7 +652,7 @@
"color": {
"mode": "thresholds"
},
"mappings": [],
"mappings": [ ],
"min": 0,
"thresholds": {
"mode": "percentage",
Expand All @@ -669,7 +669,7 @@
},
"unit": "short"
},
"overrides": []
"overrides": [ ]
},
"gridPos": {
"h": 8,
Expand Down Expand Up @@ -767,7 +767,7 @@
"mode": "off"
}
},
"mappings": [],
"mappings": [ ],
"thresholds": {
"mode": "absolute",
"steps": [
Expand All @@ -779,7 +779,7 @@
},
"unit": "short"
},
"overrides": []
"overrides": [ ]
},
"gridPos": {
"h": 8,
Expand All @@ -790,7 +790,7 @@
"id": 13,
"options": {
"legend": {
"calcs": [],
"calcs": [ ],
"displayMode": "list",
"placement": "bottom",
"showLegend": true
Expand Down Expand Up @@ -854,7 +854,7 @@
"includeAll": false,
"multi": false,
"name": "datasource",
"options": [],
"options": [ ],
"query": "prometheus",
"queryValue": "",
"refresh": 1,
Expand All @@ -872,14 +872,14 @@
"type": "prometheus",
"uid": "${datasource}"
},
"definition": "label_values(keda_scaled_object_errors, namespace)",
"definition": "label_values(keda_scaled_object_errors, exported_namespace)",
"hide": 0,
"includeAll": false,
"multi": false,
"name": "namespace",
"options": [],
"options": [ ],
"query": {
"query": "label_values(keda_scaled_object_errors, namespace)",
"query": "label_values(keda_scaled_object_errors, exported_namespace)",
"refId": "StandardVariableQuery"
},
"refresh": 1,
Expand All @@ -902,14 +902,14 @@
"type": "prometheus",
"uid": "${datasource}"
},
"definition": "label_values(keda_scaled_object_errors{namespace=\"$namespace\"}, scaledObject)",
"definition": "label_values(keda_scaled_object_errors{exported_namespace=\"$namespace\"}, scaledObject)",
"hide": 0,
"includeAll": true,
"multi": true,
"name": "scaledObject",
"options": [],
"options": [ ],
"query": {
"query": "label_values(keda_scaled_object_errors{namespace=\"$namespace\"}, scaledObject)",
"query": "label_values(keda_scaled_object_errors{exported_namespace=\"$namespace\"}, scaledObject)",
"refId": "StandardVariableQuery"
},
"refresh": 2,
Expand All @@ -928,14 +928,14 @@
"type": "prometheus",
"uid": "${datasource}"
},
"definition": "label_values(keda_scaler_errors{namespace=\"$namespace\"}, scaler)",
"definition": "label_values(keda_scaler_errors{exported_namespace=\"$namespace\"}, scaler)",
"hide": 0,
"includeAll": false,
"multi": false,
"name": "scaler",
"options": [],
"options": [ ],
"query": {
"query": "label_values(keda_scaler_errors{namespace=\"$namespace\"}, scaler)",
"query": "label_values(keda_scaler_errors{exported_namespace=\"$namespace\"}, scaler)",
"refId": "StandardVariableQuery"
},
"refresh": 2,
Expand All @@ -954,14 +954,14 @@
"type": "prometheus",
"uid": "${datasource}"
},
"definition": "label_values(keda_scaler_errors{namespace=\"$namespace\"}, metric)",
"definition": "label_values(keda_scaler_errors{exported_namespace=\"$namespace\"}, metric)",
"hide": 0,
"includeAll": false,
"multi": false,
"name": "metric",
"options": [],
"options": [ ],
"query": {
"query": "label_values(keda_scaler_errors{namespace=\"$namespace\"}, metric)",
"query": "label_values(keda_scaler_errors{exported_namespace=\"$namespace\"}, metric)",
"refId": "StandardVariableQuery"
},
"refresh": 2,
Expand All @@ -976,7 +976,7 @@
"from": "now-24h",
"to": "now"
},
"timepicker": {},
"timepicker": { },
"timezone": "",
"title": "Keda",
"uid": "asdasd8rvmMxdVk",
Expand Down

0 comments on commit 6923a4f

Please sign in to comment.