Skip to content

Commit

Permalink
modify CHANGELOG
Browse files Browse the repository at this point in the history
Signed-off-by: Kun Woo Yoo <vbtkdpf148@gmail.com>
  • Loading branch information
kunwooy committed Sep 18, 2024
1 parent a5b9fb6 commit 74b88dc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Here is an overview of all new **experimental** features:
- **GitHub Scaler**: Fixed pagination, fetching repository list ([#5738](https://github.com/kedacore/keda/issues/5738))
- **Kafka**: Fix logic to scale to zero on invalid offset even with earliest offsetResetPolicy ([#5689](https://github.com/kedacore/keda/issues/5689))
- **RabbitMQ Scaler**: Add connection name for AMQP ([#5958](https://github.com/kedacore/keda/issues/5958))
- TODO ([#XXX](https://github.com/kedacore/keda/issues/XXX))
- **CPU/Memory Scaler**: Add activation feature ([#6057](https://github.com/kedacore/keda/issues/6057))

### Fixes

Expand Down
4 changes: 2 additions & 2 deletions pkg/scalers/cpu_memory_scaler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func TestGetMetricsAndActivity_IsActive(t *testing.T) {
kubeClient := fake.NewClientBuilder().WithRuntimeObjects(createHPAWithAverageUtilization(50), createScaledObject()).Build()
scaler, _ := NewCPUMemoryScaler(v1.ResourceCPU, config, kubeClient)

_, isActive, _ := scaler.GetMetricsAndActivity(context.TODO(), "cpu")
_, isActive, _ := scaler.GetMetricsAndActivity(context.Background(), "cpu")
assert.Equal(t, isActive, true)
}

Expand All @@ -176,6 +176,6 @@ func TestGetMetricsAndActivity_IsNotActive(t *testing.T) {
kubeClient := fake.NewClientBuilder().WithRuntimeObjects(createHPAWithAverageUtilization(30), createScaledObject()).Build()
scaler, _ := NewCPUMemoryScaler(v1.ResourceCPU, config, kubeClient)

_, isActive, _ := scaler.GetMetricsAndActivity(context.TODO(), "cpu")
_, isActive, _ := scaler.GetMetricsAndActivity(context.Background(), "cpu")
assert.Equal(t, isActive, false)
}

0 comments on commit 74b88dc

Please sign in to comment.