-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
New validation hook to check if scale target is already managed
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
- Loading branch information
Showing
124 changed files
with
16,991 additions
and
250 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Build the manager binary | ||
| FROM --platform=$BUILDPLATFORM ghcr.io/kedacore/build-tools:1.18.8 AS builder | ||
|
|
||
| ARG BUILD_VERSION=main | ||
| ARG GIT_COMMIT=HEAD | ||
| ARG GIT_VERSION=main | ||
|
|
||
| WORKDIR /workspace | ||
|
|
||
| COPY Makefile Makefile | ||
|
|
||
| # Copy the go source | ||
| COPY hack/ hack/ | ||
| COPY version/ version/ | ||
| COPY cmd/ cmd/ | ||
| COPY apis/ apis/ | ||
| COPY controllers/ controllers/ | ||
| COPY pkg/ pkg/ | ||
| COPY vendor/ vendor/ | ||
| COPY go.mod go.mod | ||
| COPY go.sum go.sum | ||
|
|
||
| # Build | ||
| # https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/ | ||
| ARG TARGETOS | ||
| ARG TARGETARCH | ||
| RUN VERSION=${BUILD_VERSION} GIT_COMMIT=${GIT_COMMIT} GIT_VERSION=${GIT_VERSION} TARGET_OS=$TARGETOS ARCH=$TARGETARCH make webhooks | ||
|
|
||
| # Use distroless as minimal base image to package the manager binary | ||
| # Refer to https://github.com/GoogleContainerTools/distroless for more details | ||
| FROM gcr.io/distroless/static:nonroot | ||
| WORKDIR / | ||
| COPY --from=builder /workspace/bin/keda-webhooks . | ||
| # 65532 is numeric for nonroot | ||
| USER 65532:65532 | ||
|
|
||
| ENTRYPOINT ["/keda-webhooks", "--zap-log-level=info", "--zap-encoder=console"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| /* | ||
| Copyright 2023 The KEDA Authors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
|
|
||
| autoscalingv2 "k8s.io/api/autoscaling/v2" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| logf "sigs.k8s.io/controller-runtime/pkg/log" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook" | ||
| ) | ||
|
|
||
| var scaledobjectlog = logf.Log.WithName("scaledobject-validation-webhook") | ||
|
|
||
| var kc client.Client | ||
|
|
||
| func (r *ScaledObject) SetupWebhookWithManager(mgr ctrl.Manager) error { | ||
| kc = mgr.GetClient() | ||
| return ctrl.NewWebhookManagedBy(mgr). | ||
| For(r). | ||
| Complete() | ||
| } | ||
|
|
||
| // +kubebuilder:webhook:path=/validate-keda-sh-v1alpha1-scaledobject,mutating=false,failurePolicy=ignore,sideEffects=None,groups=keda.sh,resources=scaledobjects,verbs=create;update,versions=v1alpha1,name=vscaledobject.kb.io,admissionReviewVersions=v1 | ||
| // +kubebuilder:rbac:groups=admissionregistration.k8s.io,resources=validatingwebhookconfigurations,verbs=get;list;watch;update;patch | ||
| // +kubebuilder:rbac:groups="",namespace=keda,resources=secrets,verbs=get;list;watch;create;update;patch;delete | ||
|
|
||
| var _ webhook.Validator = &ScaledObject{} | ||
|
|
||
| // ValidateCreate implements webhook.Validator so a webhook will be registered for the type | ||
| func (r *ScaledObject) ValidateCreate() error { | ||
| val, _ := json.MarshalIndent(r, "", " ") | ||
| scaledobjectlog.V(1).Info(fmt.Sprintf("validating scaledobject creation for %s", string(val))) | ||
| return validateWorkload(r) | ||
| } | ||
|
|
||
| func (r *ScaledObject) ValidateUpdate(old runtime.Object) error { | ||
| val, _ := json.MarshalIndent(r, "", " ") | ||
| scaledobjectlog.V(1).Info(fmt.Sprintf("validating scaledobject update for %s", string(val))) | ||
| return validateWorkload(r) | ||
| } | ||
|
|
||
| func validateWorkload(so *ScaledObject) error { | ||
| hpaList := &autoscalingv2.HorizontalPodAutoscalerList{} | ||
| opt := &client.ListOptions{ | ||
| Namespace: so.Namespace, | ||
| } | ||
| err := kc.List(context.Background(), hpaList, opt) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| for _, hpa := range hpaList.Items { | ||
| val, _ := json.MarshalIndent(hpa, "", " ") | ||
| scaledobjectlog.V(1).Info(fmt.Sprintf("checking hpa %s: %v", hpa.Name, string(val))) | ||
| hpaTarget := hpa.Spec.ScaleTargetRef | ||
| soTarget := so.Spec.ScaleTargetRef | ||
|
|
||
| hpaTargetAPI := "apps/v1" | ||
| if hpaTarget.APIVersion != "" { | ||
| hpaTargetAPI = hpaTarget.APIVersion | ||
| } | ||
| hpaTargetKind := "Deployment" | ||
| if hpaTarget.Kind != "" { | ||
| hpaTargetKind = hpaTarget.Kind | ||
| } | ||
| soTargetAPI := "apps/v1" | ||
| if soTarget.APIVersion != "" { | ||
| soTargetAPI = soTarget.APIVersion | ||
| } | ||
| soTargetKind := "Deployment" | ||
| if soTarget.Kind != "" { | ||
| soTargetKind = soTarget.Kind | ||
| } | ||
|
|
||
| if hpaTargetAPI == soTargetAPI && | ||
| hpaTargetKind == soTargetKind && | ||
| hpaTarget.Name == soTarget.Name { | ||
| labels := hpa.GetLabels() | ||
| if val, ok := labels[ScaledObjectOwnerAnnotation]; !ok || val != so.Name { | ||
| err := fmt.Errorf("the workload %s of type %s/%s is already managed by the hpa %s, and it isn't managed by this scaledobject", soTarget.Name, soTargetAPI, soTargetKind, hpa.Name) | ||
| scaledobjectlog.Error(err, "validation error") | ||
| return err | ||
| } | ||
| } | ||
| } | ||
| scaledobjectlog.V(1).Info(fmt.Sprintf("scaledobject %s is valid", so.Name)) | ||
| return nil | ||
| } | ||
|
|
||
| func (r *ScaledObject) ValidateDelete() error { | ||
| return nil | ||
| } |
Oops, something went wrong.