Skip to content

Commit

Permalink
chore: improve string normalization for metric names (#3862)
Browse files Browse the repository at this point in the history
Fixes #3789
  • Loading branch information
JorTurFer authored Nov 16, 2022
1 parent cd38e83 commit dab87b5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
- **General:** Add explicit seccompProfile type to securityContext config ([#3561](https://github.com/kedacore/keda/issues/3561))
- **General:** Add `Min` column to ScaledJob visualization ([#3689](https://github.com/kedacore/keda/issues/3689))
- **General:** Add support to use pod identities for authentication in Azure Key Vault ([#3813](https://github.com/kedacore/keda/issues/3813)
- **General:** Improve the function used to normalize metric names ([#3789](https://github.com/kedacore/keda/issues/3789)
- **Apache Kafka Scaler:** SASL/OAuthbearer Implementation ([#3681](https://github.com/kedacore/keda/issues/3681))
- **Azure AD Pod Identity Authentication:** Improve error messages to emphasize problems around the integration with aad-pod-identity itself ([#3610](https://github.com/kedacore/keda/issues/3610))
- **Azure Event Hub Scaler:** Support Azure Active Direcotry Pod & Workload Identity for Storage Blobs ([#3569](https://github.com/kedacore/keda/issues/3569))
Expand Down
2 changes: 2 additions & 0 deletions pkg/util/normalize_string.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ func NormalizeString(s string) string {
s = strings.ReplaceAll(s, ".", "-")
s = strings.ReplaceAll(s, ":", "-")
s = strings.ReplaceAll(s, "%", "-")
s = strings.ReplaceAll(s, "(", "-")
s = strings.ReplaceAll(s, ")", "-")
return s
}

Expand Down

0 comments on commit dab87b5

Please sign in to comment.