Use http.Client instead of http.Get

[aman-bansal]

At many places, HTTP requests have been implemented using default HTTP client like r, err := http.Get(s.metadata.url). As per HTTP package, default client is defined like this var DefaultClient = &Client{}. This has huge drawbacks as it doesn't allow the application to define timeout behaviors (among other things). The default value of timeout is 0 which means no timeout. In production environments, this could prove costly. The more intuitive way would be to create your own client like

client := &http.Client{
	Timeout: x * time.Second, // x seconds timeout
}

and http.NewRequest() to create new requests.

[turbaszek]

@aman-bansal do you think we should allow users to specify such parameters on a case by case basis or should we introduce good-enough default?

[aman-bansal]

There are two ways to look at this:

1. In cases of client-controlled logic like metricsAPIScaler, it makes more sense to define timeouts on a case by case basis based on their application logic, scale, and use cases.
2. For other scalers provided by Identity Providers like AWS, AZURE, it makes more sense to define a good enough default.

What I think is we should define one parameter in metadata for each scaler (where timeouts make sense) with good enough default value.

[arschles]

I agree with both of those points @aman-bansal, but I would add that we should allow users to set a global timeout should they desire.

I would like to work on this. I'll send a draft PR as a start.

[tomkerkhove]

Created kedacore/charts#109 to surface this in our Helm chart as well.

[arschles]

@aman-bansal after #1758, I don't see anywhere else that uses raw http.Get or http.Client{} values without timeouts. Do you see anywhere I'm missing?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[zroubalik]

This has been done, we can close this issue.