-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add Expression field to AWS CloudWatch scaler #1619
Comments
Interesting request as this could be interesting for multiple scalers. What would the expression look like? |
I would imagine they mean a CloudWatch expression. We hardwire things to MetricStat here https://github.com/kedacore/keda/blob/main/pkg/scalers/aws_cloudwatch_scaler.go#L278 but CloudWatch allows asking for either a single metric or an expression https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDataQuery.html |
Makes sense to have this as a field indeed! Are you willing to contribute this @jeffjen ? |
I can work on this My proposed change will be to not mess with multiple metrics in a query since it will change the struct to include an array of dimensions / namespace The first step will be to just provide a way to add Math Expression for a single metric on designated dimension and namespace. |
Thanks! I don't know how the SDK works but I'd just add a new optional |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
/keep-alive |
I've opened this PR to add alternative expression field and also changed the scaler to use int64 instead of float64. |
I'd say that this is done by kedacore/keda-docs#755. Feel free to reopen the issue if it's not done |
Proposal
We'd like to add simple math aggregation to our metric data.
As it stands, we need to write a Lambda Function to poll and compute new metric data from a set of metrics, and then publish them back to cloudwatch.
Would be nice to be able to perform this kind of operation without need to provision Lambda
Use-Case
According to https://forums.aws.amazon.com/thread.jspa?threadID=309159
We can get a rough estimate on how many active connections are there by performing math expression.
The text was updated successfully, but these errors were encountered: