Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alternative expression field in AWS CloudWatch scaler #755

Merged
merged 2 commits into from
May 4, 2022

Conversation

dekelev
Copy link
Contributor

@dekelev dekelev commented May 4, 2022

Signed-off-by: Dekel Barzilay dekelev@gmail.com

Relates to changes from these PRs kedacore/keda#2911 & kedacore/keda#2997

Added alternative expression field in AWS CloudWatch scaler.
Here's an example ScaledObject config:

awsRegion: us-east-1
expression: >-
  SELECT MIN(MessageCount) FROM "AWS/AmazonMQ" WHERE Broker =
  'production' and Queue = 'worker'
metricCollectionTime: '60'
metricName: WorkerMessageCount
metricStatPeriod: '60'
minMetricValue: '0'
namespace: AWS/AmazonMQ
targetMetricValue: '100'

Checklist

  • [ x] Commits are signed with Developer Certificate of Origin (DCO)

Signed-off-by: Dekel Barzilay <dekelev@gmail.com>
@netlify
Copy link

netlify bot commented May 4, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit cf803b4
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/627283de2e360e0009a3b4dc
😎 Deploy Preview https://deploy-preview-755--keda.netlify.app/docs/2.7/scalers/aws-cloudwatch
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, instead of explaining those fields there, mark them as optional and describe them in the section Parameter lists:(below).
I mean, take the descriptions from these 3 fields and add them below (I know that they are already wrong), we follow this convention for having a unified documentation (but sometimes this could happen)

Signed-off-by: Dekel Barzilay <dekelev@gmail.com>
@dekelev
Copy link
Contributor Author

dekelev commented May 4, 2022

Please, instead of explaining those fields there, mark them as optional and describe them in the section Parameter lists:(below). I mean, take the descriptions from these 3 fields and add them below (I know that they are already wrong), we follow this convention for having a unified documentation (but sometimes this could happen)

Done

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants