KEDA should make sure generate correct labels for HPA

[anggao]

Report

2021-02-22T14:36:15.195Z ERROR controllers.ScaledObject Failed to ensure HPA is correctly created for ScaledObj
ect {“ScaledObject.Namespace”: “XXXXXXX”, “ScaledObject.Name”: “XXXXXXXX-0-model-pod”, “error”: “HorizontalPodAutoscaler.autoscaling \“keda-hpa-XXXXXXXX\” is invalid: metadata.labels: Invalid value: \“keda-hpa-XXXXXXXXXX-\“: a valid label must be an empty string or consist of alphanumeric characters, ‘-’, ‘’ or ‘.’, and must start and end wit
h an alphanumeric character (e.g. ‘MyValue’, or ‘my_value’, or ‘12345’, regex used for validation is ‘(([A-Za-z0-9][-A-Za-z0-
9.]*)?[A-Za-z0-9])?’)“}

Expected Behavior

KEDA should make sure the generated labels are correct

Actual Behavior

if len(labelName) > 63 {
	labelName = labelName[:63]
}

Steps to Reproduce the Problem

Create a KEDA scaled object with name like sort-accommodation-aaaaaa-aaaa-accommodation-aaaaaa-0-model-pod

Logs from KEDA operator

example

KEDA Version

2.0.0

Kubernetes Version

1.18

Platform

Other

Scaler Details

No response