Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KEDA generated hpa label #1631

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Fix KEDA generated hpa label #1631

merged 2 commits into from
Feb 23, 2021

Conversation

anggao
Copy link
Contributor

@anggao anggao commented Feb 22, 2021

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #1630

@anggao anggao force-pushed the fix-hpa-label branch 4 times, most recently from 18b9e9c to acc20ef Compare February 22, 2021 21:12
Signed-off-by: Ang Gao <ang.gao87@gmail.com>
Signed-off-by: Ang Gao <ang.gao87@gmail.com>
@ahmelsayed
Copy link
Contributor

Thanks @anggao!

@ahmelsayed ahmelsayed merged commit 7fe2ab2 into kedacore:main Feb 23, 2021
@anggao
Copy link
Contributor Author

anggao commented Feb 23, 2021

@ahmelsayed do you have an ETA when this can be released ?

ycabrer pushed a commit to ycabrer/keda that referenced this pull request Mar 1, 2021
* Fix KEDA generated hpa label

Signed-off-by: Ang Gao <ang.gao87@gmail.com>

* Add changelog

Signed-off-by: Ang Gao <ang.gao87@gmail.com>
Rodolfodc pushed a commit to sidilabs/keda that referenced this pull request Mar 11, 2021
* Fix KEDA generated hpa label

Signed-off-by: Ang Gao <ang.gao87@gmail.com>

* Add changelog

Signed-off-by: Ang Gao <ang.gao87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KEDA should make sure generate correct labels for HPA
3 participants