Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate e2e test for CPU scaler to Go. #3169

Closed
Tracked by #2737
v-shenoy opened this issue Jun 13, 2022 · 3 comments · Fixed by #3213
Closed
Tracked by #2737

Migrate e2e test for CPU scaler to Go. #3169

v-shenoy opened this issue Jun 13, 2022 · 3 comments · Fixed by #3213
Assignees
@aviadlevy
Labels
help wanted Looking for support from community testing

Comments

@v-shenoy
Copy link
Contributor

v-shenoy commented Jun 13, 2022 •
edited
Loading

Proposal

Relates to #2357, #2737.

Use-Case

No response

Anything else?

No response
@v-shenoy v-shenoy added needs-discussion feature-request All issues for new features that have not been committed to help wanted Looking for support from community testing and removed needs-discussion feature-request All issues for new features that have not been committed to labels Jun 13, 2022
@v-shenoy v-shenoy mentioned this issue Jun 13, 2022
Open
35 tasks
@zroubalik zroubalik mentioned this issue Jun 13, 2022
Closed
48 tasks
@aviadlevy
Copy link
Contributor

I started working on that. Hoping to open PR soon

aviadlevy added a commit to aviadlevy/keda that referenced this issue Jun 21, 2022
@aviadlevy
e2e - cpu
522dc7f 
Resolve kedacore#3169

Signed-off-by: aviadlevy <aviadlevy1@gmail.com>
@aviadlevy aviadlevy mentioned this issue Jun 21, 2022
Merged
3 tasks
@Ritikaa96
Copy link
Contributor

Hi @JorTurFer Just couldn't skip this one, I'm curious, we had a check last time for job status because sometimes jobs tend to be erroneous after they are successfully applied, or we can say the pods it will run may cause some error. if the e2e is passing on our ci/cd side for some reason now, don't we still need to check job status as a precaution for the future?
WDYT?

@JorTurFer
Copy link
Member

as we discussed in slack, it's not required even it's a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aviadlevy aviadlevy

Labels
help wanted Looking for support from community testing
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate e2e test for CPU scaler to Go. aviadlevy/keda
4 participants
@aviadlevy @JorTurFer @v-shenoy @Ritikaa96