Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split e2e by type #3270

Closed
JorTurFer opened this issue Jun 23, 2022 · 2 comments · Fixed by #3283
Closed

Split e2e by type #3270

JorTurFer opened this issue Jun 23, 2022 · 2 comments · Fixed by #3283
Assignees
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Jun 23, 2022

Proposal

I'm thinking on e2e tests and how they are organized. Should we create more folders than scalers to split the tests by funcionality?
I said because for instance, hashicorp vault e2e test is using postgres, but the important thing of that test is not postgres scaler at all, and the same with aad-pod-identity/workload-federation, or for the HPA pause and custom names. Maybe we could split e2e test in different folders based on the thing that are testing, of course for testing Vault we need an scaler, but doesn't matter which scaler.
My proposal for the moment is having 3 folders:

  • Scalers: For scaler stuffs
  • Secret-providers: For e2e test about all the things related with secrets
  • Internals: For e2e test about internal mechanism, like hpa pause, hpa custom name, etc
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Jun 23, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Jun 23, 2022
@tomkerkhove
Copy link
Member

I'm ok with introducing a bit of structure, but I wouldn't go too far as it might make it more complex and reduce the efficiency of new contributions.

@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 23, 2022

no no, my proposal is having 3 or 4 folders maximum, just for spliting in the biggest areas. We don't need more atm

@JorTurFer JorTurFer self-assigned this Jul 4, 2022
Repository owner moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Jul 5, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants