Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Split e2e by type #3283

Merged
merged 11 commits into from
Jul 5, 2022
Merged

chore: Split e2e by type #3283

merged 11 commits into from
Jul 5, 2022

Conversation

JorTurFer
Copy link
Member

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3270

@JorTurFer JorTurFer requested a review from a team as a code owner June 26, 2022 18:26
@JorTurFer JorTurFer requested a review from v-shenoy June 26, 2022 19:17
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 26, 2022

/run-e2e
Update: You can check the progress here

Copy link
Contributor

@v-shenoy v-shenoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions for folder names here. Maybe auth instead of secret-providers. Also assets sounds somewhat off, how about common?

Otherwise, looks good!

@JorTurFer
Copy link
Member Author

I'm not sure about auth, because it could be confusing with scaler auths, my idea is to split external secret providers like vault, key vault, or pod identities here...
I like common over assets, tomorrow I'll change it :)

@v-shenoy
Copy link
Contributor

v-shenoy commented Jun 27, 2022

I'm not sure about auth, because it could be confusing with scaler auths, my idea is to split external secret providers like vault, key vault, or pod identities here... I like common over assets, tomorrow I'll change it :)

Makes sense. To get a bit more clarity, where do tests for things like pod identity / workload identity go?

tests/README.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member Author

I'm not sure about auth, because it could be confusing with scaler auths, my idea is to split external secret providers like vault, key vault, or pod identities here... I like common over assets, tomorrow I'll change it :)

Makes sense. To get a bit more clarify, where do tests for things like pod identity / workload identity go?

My idea is put them also in this secret-provider folders because they provide the tokens under the hood

@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 27, 2022

/run-e2e
Update: You can check the progress here

@v-shenoy
Copy link
Contributor

v-shenoy commented Jun 27, 2022

out, err := ExecuteCommandWithDir("make deploy", "..")

This is causing the problem. The path is incorrect, @JorTurFer

@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 28, 2022

/run-e2e
Update: You can check the progress here

@v-shenoy
Copy link
Contributor

Just one thing, I added some tests for workload identity in scalers_go that need to be moved.

@JorTurFer JorTurFer requested a review from zroubalik June 28, 2022 12:21
JorTurFer and others added 10 commits July 5, 2022 08:53
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Copy link
Member Author

Just one thing, I added some tests for workload identity in scalers_go that need to be moved.

Rebased, PTAL @v-shenoy and I'll merge after is ready to avoid more rebases xD

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 5, 2022

/run-e2e
Update: You can check the progress here

@v-shenoy
Copy link
Contributor

v-shenoy commented Jul 5, 2022

Just one thing, I added some tests for workload identity in scalers_go that need to be moved.

Rebased, PTAL @v-shenoy and I'll merge after is ready to avoid more rebases xD

Yeah, I am not adding any changes rn. But there are some test PRs in review it seems, maybe this should be merged before them :P

@JorTurFer
Copy link
Member Author

Yeah, I am not adding any changes rn. But there are some test PRs in review it seems, maybe this should be merged before them :P

I think so, to not rebase them again xD

@JorTurFer JorTurFer merged commit c0934de into kedacore:main Jul 5, 2022
@JorTurFer JorTurFer deleted the split-e2e branch July 5, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split e2e by type
4 participants