-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Split e2e by type #3283
chore: Split e2e by type #3283
Conversation
/run-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some suggestions for folder names here. Maybe auth
instead of secret-providers
. Also assets
sounds somewhat off, how about common
?
Otherwise, looks good!
I'm not sure about auth, because it could be confusing with scaler auths, my idea is to split external secret providers like vault, key vault, or pod identities here... |
Makes sense. To get a bit more clarity, where do tests for things like pod identity / workload identity go? |
My idea is put them also in this secret-provider folders because they provide the tokens under the hood |
/run-e2e |
Line 101 in b4299cc
This is causing the problem. The path is incorrect, @JorTurFer |
/run-e2e |
Just one thing, I added some tests for workload identity in |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Rebased, PTAL @v-shenoy and I'll merge after is ready to avoid more rebases xD |
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
/run-e2e |
Yeah, I am not adding any changes rn. But there are some test PRs in review it seems, maybe this should be merged before them :P |
I think so, to not rebase them again xD |
Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es
Checklist
Fixes #3270