-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composed (Logical/Priority) Triggers #3330
Comments
hey @theauheral |
Hello @JorTurFer, Yes maybe. Different use cases but same technical implementation I suspect. I would say related but not identical. I see "Combination of triggers can be used, either with an OR or AND fashion." which is similar yes. You could definitely build the two feature requests in one. |
Yes, you are right. |
Yeah, what we can do is to provide just one metric to HPA in this case and calculate the formula consisting of multiple triggers on KEDA side. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Keep-Alive |
@tomkerkhove any update on this? |
@tomkerkhove, any update on this? |
Nope, are you willing to contribute it? |
This is already covered by Scaling Modifiers https://keda.sh/docs/2.14/concepts/scaling-deployments/#scaling-modifiers-experimental I belive we can close this issue already. |
Hi @zroubalik, I have a use case where I need to scale my application in and out based on the Azure Service Bus queue length and Azure SQL CPU. Below is the condition I am planning to use for scaling. How can I implement this using Scaling Modifiers? I plan to use the Azure Service Bus scalar to get the queue length and the Azure Monitor scalar to monitor the Azure SQL Managed Instance CPU. Appreciate your help. Thanks. Scaling Out Condition: Scale out when both conditions are met:
Scaling In Condition: Scale in when any of the following conditions are true:
|
@ghantasunil In theory this should be possible using a formula applied to two triggers, one based on queue length and one based on CPU. However, as per #4992 formulas cannot be applied to a CPU trigger |
Proposal
I would like to suggest a new feature: composed (Logical/Priority) triggers.
Use-Case
I would like to be able to compose triggers or define a logic/priority between triggers.
Example:
Scaling from 0 to 1<=n<=maxReplicas replicas on a fixed CRON schedule (On/Off) with n managed by the metric (kafka) trigger during the runtime window.
The current design only enables "OR" logic between triggers. I would like to specify an "AND" logic between triggers or a priority of evaluation between triggers. Check trigger 1, if true then check trigger 2.
Anything else?
Specification
Possible inspiration: Log4J2 rules and triggers for rotating files based on time and file size
The text was updated successfully, but these errors were encountered: