Detect Inf before casting float to int

[bboreham]

Report

This line:

keda/pkg/scalers/prometheus_scaler.go

Line 310 in 4e72030

metric := GenerateMetricInMili(metricName, val)

is called on output from Prometheus, which may be +Inf.

It calls

keda/pkg/scalers/scaler.go

Line 189 in 4e72030

valueMili := int64(value * 1000)

where the value is cast to an int. This does not go well; it might result in a number like -9223372036854776000.

Expected Behavior

Not generate bogus values. Maybe treat it the same as "null", handled a few lines earlier?

Actual Behavior

Steps to Reproduce the Problem

Sorry I don't know much about running Keda; I'm debugging someone else's problem.
For the purpose of demonstrating the problem, you can use PromQL 1/0, that returns +Inf.

Logs from KEDA operator

No response

KEDA Version

2.7.1

Kubernetes Version

1.22

Platform

Google Cloud

Scaler Details

HPA

Anything else?

No response

[dannykopping]

It would be greatly appreciated if the fix could be backported to v2.7 as we (Grafana Labs, who ❤️ KEDA!) are currently staying one minor version behind for stability.

[JorTurFer]

hey,
This make sense totally, are you willing to contribute with the fix?

[JorTurFer]

It would be greatly appreciated if the fix could be backported to v2.7 as we (Grafana Labs, who ❤️ KEDA!) are currently staying one minor version behind for stability.

For the moment, we don't backport changes, each release is distributed as it is, sorry :(
Am I right @kedacore/keda-core-contributors ?

[JorTurFer]

Another question, are you open to be listed as KEDA users 😄 ?
https://github.com/kedacore/keda-docs#become-a-listed-keda-user

[JorTurFer]

@kedacore/keda-core-contributors ? 🔝 🔝

[JorTurFer]

@kedacore/keda-core-contributors ?
#3644 (comment)

[JorTurFer]

hey @bboreham
Do you think this change could be enough? #3762