-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace k8s.io/client-go/scale
with controller-runtime client
#4013
Comments
This MR above has been included in |
@dttung2905 great, thanks! |
Update: It is needed to update the |
@dttung2905 thanks for the heads up! |
Proposal
controller-runtime client will soon support accessing
/scale
subresource:kubernetes-sigs/controller-runtime#2094
kubernetes-sigs/controller-runtime#172
Once a version of controller-runtime with this change is released we should use it and consolidate our codebase ->
replace
k8s.io/client-go/scale
with controller-runtime client.It is in the ScaledObject controller and scale executor:
keda/controllers/keda/scaledobject_controller.go
Line 67 in f4bee67
keda/pkg/scaling/executor/scale_executor.go
Line 47 in f4bee67
The text was updated successfully, but these errors were encountered: