Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace k8s.io/client-go/scale with controller-runtime client #4013

Open
zroubalik opened this issue Dec 14, 2022 · 4 comments · Fixed by #4107
Open

Replace k8s.io/client-go/scale with controller-runtime client #4013

zroubalik opened this issue Dec 14, 2022 · 4 comments · Fixed by #4107
Assignees
@dttung2905
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@zroubalik
Copy link
Member

zroubalik commented Dec 14, 2022 •
edited
Loading

Proposal

controller-runtime client will soon support accessing /scale subresource:
kubernetes-sigs/controller-runtime#2094
kubernetes-sigs/controller-runtime#172

Once a version of controller-runtime with this change is released we should use it and consolidate our codebase ->
replace k8s.io/client-go/scale with controller-runtime client.

It is in the ScaledObject controller and scale executor:

keda/controllers/keda/scaledobject_controller.go

Line 67 in f4bee67

ScaleClient scale.ScalesGetter

keda/pkg/scaling/executor/scale_executor.go

Line 47 in f4bee67

scaleClient scale.ScalesGetter

@zroubalik zroubalik added help wanted Looking for support from community needs-discussion feature-request All issues for new features that have not been committed to labels Dec 14, 2022
@zroubalik zroubalik moved this to Proposed in Roadmap - KEDA Core Dec 14, 2022
@zroubalik zroubalik moved this from Proposed to To Do in Roadmap - KEDA Core Dec 14, 2022
@zroubalik zroubalik added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Dec 14, 2022
@dttung2905
Copy link
Contributor

This MR above has been included in 0.14.0 of the sigs.k8s.io/controller-runtime (Changelog).
Can I take up this task, if you don't mind ? I'm reading up on the documentation for controller-runtime to catch up on the missing knowledge but will definitely need your help/guidance along the way

@zroubalik
Copy link
Member Author

@dttung2905 great, thanks!

@dttung2905
Copy link
Contributor

Update: It is needed to update thepredictkube-libs as well. It uses older version of k8s.io/client-go which has breaking changes in the latest version
PR: dysnix/predictkube-libs#7

@zroubalik
Copy link
Member Author

@dttung2905 thanks for the heads up!

This was referenced Jan 11, 2023
Merged
Merged
@github-project-automation github-project-automation bot moved this from To Do to Ready To Ship in Roadmap - KEDA Core Jan 20, 2023
@zroubalik zroubalik reopened this Jan 20, 2023
@github-project-automation github-project-automation bot moved this from Ready To Ship to Proposed in Roadmap - KEDA Core Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dttung2905 dttung2905

Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Roadmap - KEDA Core
Status: Proposed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor tests when moving to k8s.io/client-go v0.26.0 dttung2905/keda
2 participants
@zroubalik @dttung2905