-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s.io/client-go and k8s.io/apiserver to v0.26.0 #143
Bump k8s.io/client-go and k8s.io/apiserver to v0.26.0 #143
Conversation
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
Welcome @dttung2905! |
Hi @dttung2905. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, thanks @dttung2905!
Just one thing: please update the generated OpenAPI definitions by running:
touch go.mod # to force the generation if needed
make
(it should be detected by CI but it is not verified yet)
/triage accepted
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Thanks alot @olivierlemasle for the super quick review! . I have generated OpenAPI definitions as you suggested. Could you help to review it again 🙏 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dttung2905
/lgtm
/assign @dgrisonnet
Awesome, thank you @dttung2905! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, dttung2905, olivierlemasle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi team,
Happy New Year!
This MR is meant to bump
k8s.io/client-go
andk8s.io/apiserver
to v0.26.0.There was a refactoring for method
WriteObjectNegotiated()
that requires a minor change (source)Reason: This MR is a prerequisite for this issue in KEDA kedacore/keda#4013 where we want benefit from some new features in
k8s.io/client-go
v0.26.0https://github.com/kedacore/keda/blob/64e734bad185ecc93dee2d2df67ea0a3a65b0845/go.mod#L88
Please let me know your feedback on this. 🙏