Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Go SDK Upgrade #4905

Closed
jeevanragula opened this issue Aug 24, 2023 · 3 comments · Fixed by #4953
Closed

AWS Go SDK Upgrade #4905

jeevanragula opened this issue Aug 24, 2023 · 3 comments · Fixed by #4953
Assignees
@jeevanragula
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@jeevanragula
Copy link
Contributor

Proposal

In the Keda project, we are currently using below AWS Go SDK version.

github.com/aws/aws-sdk-go v1.44.287

But AWS released a V2 version long back which has few advantages over V1.

Below are the snippets from their docs.

The AWS SDK for Go v2 requires Go 1.15 or higher, and offers significant performance improvements in CPU and memory utilization over version 1. Review our Developer Guide to get started with AWS SDK for Go v2 or review the migration guide if you already use version 1.

The AWS SDK for Go V2 has been updated to take advantage of the Go modules which became the default development mode in Go 1.13. A number of packages provided by the SDK have been modularized and are independently versioned and released respectively. This change enables improved application dependency modeling, and enables the SDK to provide new features and functionality that follows the Go module versioning strategy.

Docs
https://aws.amazon.com/blogs/developer/aws-sdk-for-go-version-2-general-availability/

Migrating to the AWS SDK for Go V2
https://aws.github.io/aws-sdk-go-v2/docs/

We can upgrade to AWS SDK V2.

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response
@jeevanragula jeevanragula added feature-request All issues for new features that have not been committed to needs-discussion labels Aug 24, 2023
@JorTurFer
Copy link
Member

This is a nice improvement indeed.
Would you be willing to contribute with this?

@jeevanragula
Copy link
Contributor Author

@JorTurFer Yes, I can take up this.

@JorTurFer
Copy link
Member

nice! ❤️

This was referenced Sep 2, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevanragula jeevanragula

Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AWS SDK V2 Upgrade and update scalers jeevanragula/keda
AWS SDK V2 Upgrade jeevanragula/keda
2 participants
@jeevanragula @JorTurFer