Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDK V2 Upgrade and update scalers #4953

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

jeevanragula
Copy link
Contributor

In the Keda project, we are currently using below AWS Go SDK version.

github.com/aws/aws-sdk-go v1.44.287

But AWS released a V2 version long back which has few advantages over V1.
This PR is to update the code to use AWS SDK V2.

Checklist

Fixes #4905

Relates to #4905

Signed-off-by: Jeevan Reddy Ragula <jeevanragula@gmail.com>
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@jeevanragula jeevanragula marked this pull request as ready for review September 7, 2023 07:47
@jeevanragula jeevanragula requested a review from a team as a code owner September 7, 2023 07:47
@jeevanragula jeevanragula mentioned this pull request Sep 7, 2023
7 tasks
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution 🙇

@JorTurFer
Copy link
Member

JorTurFer commented Sep 7, 2023

/run-e2e aws
Update: You can check the progress here

Signed-off-by: Jeevan Reddy Ragula <jeevanragula@gmail.com>
@JorTurFer
Copy link
Member

JorTurFer commented Sep 8, 2023

/run-e2e aws
Update: You can check the progress here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 791c895 into kedacore:main Sep 8, 2023
18 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Signed-off-by: Jeevan Reddy Ragula <jeevanragula@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Go SDK Upgrade
3 participants